From 15b3e956d4f43237c422d7ce8c208043cc8bb868 Mon Sep 17 00:00:00 2001 From: Lukas Schmelting Date: Thu, 20 Jan 2022 11:55:30 +0100 Subject: [PATCH 1/3] Support debug=True if namespace-packages are present --- dash/dash.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dash/dash.py b/dash/dash.py index 85b1635665..6de775543e 100644 --- a/dash/dash.py +++ b/dash/dash.py @@ -1731,12 +1731,14 @@ def enable_dev_tools( if isinstance(package, ModuleSpec) else os.path.dirname(package.path) if hasattr(package, "path") + else os.path.dirname(package._path[0]) + if hasattr(package, "_path") else package.filename for package in packages ] for i, package in enumerate(packages): - if "dash/dash" in os.path.dirname(package.path): + if hasattr(package, "path") and "dash/dash" in os.path.dirname(package.path): component_packages_dist[i : i + 1] = [ os.path.join(os.path.dirname(package.path), x) for x in ["dcc", "html", "dash_table"] From 6f97dc36a3539041bff762842ce102eb337649ab Mon Sep 17 00:00:00 2001 From: Lukas Schmelting Date: Fri, 28 Jan 2022 08:44:21 +0100 Subject: [PATCH 2/3] Added changelog entry, disable protected-access linting to _path --- CHANGELOG.md | 2 ++ dash/dash.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0b02bf10bc..97430e4575 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -193,6 +193,8 @@ This project adheres to [Semantic Versioning](https://semver.org/). - [#1778](https://github.com/plotly/dash/pull/1778) DataTable: Fix React warnings stating that each child in a list should have a unique "key" prop +- [#1895](https://github.com/plotly/dash/pull/1895) Support debug=True if native namespace-packages are present + ## [2.0.0] - 2021-08-03 ## Dash and Dash Renderer diff --git a/dash/dash.py b/dash/dash.py index 6de775543e..7f350cb5c6 100644 --- a/dash/dash.py +++ b/dash/dash.py @@ -1731,7 +1731,7 @@ def enable_dev_tools( if isinstance(package, ModuleSpec) else os.path.dirname(package.path) if hasattr(package, "path") - else os.path.dirname(package._path[0]) + else os.path.dirname(package._path[0]) # pylint: disable=protected-access if hasattr(package, "_path") else package.filename for package in packages From eb85b7680c4580d5ea8cfe9b2c63be9637397447 Mon Sep 17 00:00:00 2001 From: alexcjohnson Date: Fri, 28 Jan 2022 11:21:58 -0500 Subject: [PATCH 3/3] black --- dash/dash.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/dash/dash.py b/dash/dash.py index 7f350cb5c6..3073d42503 100644 --- a/dash/dash.py +++ b/dash/dash.py @@ -1731,14 +1731,18 @@ def enable_dev_tools( if isinstance(package, ModuleSpec) else os.path.dirname(package.path) if hasattr(package, "path") - else os.path.dirname(package._path[0]) # pylint: disable=protected-access + else os.path.dirname( + package._path[0] # pylint: disable=protected-access + ) if hasattr(package, "_path") else package.filename for package in packages ] for i, package in enumerate(packages): - if hasattr(package, "path") and "dash/dash" in os.path.dirname(package.path): + if hasattr(package, "path") and "dash/dash" in os.path.dirname( + package.path + ): component_packages_dist[i : i + 1] = [ os.path.join(os.path.dirname(package.path), x) for x in ["dcc", "html", "dash_table"]