From fc640e38418a2c6d0598cd890ef9935375bae592 Mon Sep 17 00:00:00 2001 From: Ann Marie Ward Date: Fri, 4 Jun 2021 13:44:21 -0700 Subject: [PATCH 1/2] fix: make devtools text visible with dark themes --- .../src/components/error/GlobalErrorOverlay.css | 1 + dash/dash-renderer/src/components/error/menu/DebugMenu.css | 1 + tests/integration/devtools/test_devtools_error_handling.py | 5 ++++- 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/dash/dash-renderer/src/components/error/GlobalErrorOverlay.css b/dash/dash-renderer/src/components/error/GlobalErrorOverlay.css index 023df8db50..763f6a01fd 100644 --- a/dash/dash-renderer/src/components/error/GlobalErrorOverlay.css +++ b/dash/dash-renderer/src/components/error/GlobalErrorOverlay.css @@ -5,6 +5,7 @@ font-family: monospace; font-size: 14px; font-variant-ligatures: common-ligatures; + color: rgb(50, 50, 50); } .dash-error-card { diff --git a/dash/dash-renderer/src/components/error/menu/DebugMenu.css b/dash/dash-renderer/src/components/error/menu/DebugMenu.css index 092e379db2..b00ab401c2 100644 --- a/dash/dash-renderer/src/components/error/menu/DebugMenu.css +++ b/dash/dash-renderer/src/components/error/menu/DebugMenu.css @@ -163,6 +163,7 @@ border-radius: 32px; background-color: white; padding: 4px; + color: rgb(50, 50, 50); } .dash-debug-error-count { diff --git a/tests/integration/devtools/test_devtools_error_handling.py b/tests/integration/devtools/test_devtools_error_handling.py index caa9b57342..0091549729 100644 --- a/tests/integration/devtools/test_devtools_error_handling.py +++ b/tests/integration/devtools/test_devtools_error_handling.py @@ -7,7 +7,10 @@ def app_with_errors(): - app = dash.Dash(__name__) + darkly = ( + "https://stackpath.bootstrapcdn.com/bootswatch/4.5.2/darkly/bootstrap.min.css" + ) + app = dash.Dash(__name__, external_stylesheets=[darkly]) app.layout = html.Div( [ From d0400624cb5361c950a0f1fac2094ed1e09486eb Mon Sep 17 00:00:00 2001 From: Ann Marie Ward Date: Fri, 4 Jun 2021 15:42:05 -0700 Subject: [PATCH 2/2] CHANGELOG.md for 1664 --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 85e50759a7..fbd4becf68 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ This project adheres to [Semantic Versioning](https://semver.org/). - [#1611](https://github.com/plotly/dash/pull/1611) Package dash-renderer artifacts and dependencies with Dash, and source renderer resources from within Dash. ### Fixed +- [#1664](https://github.com/plotly/dash/pull/1664) Fix [#1649](https://github.com/plotly/dash/issues/1649), makes the devtools readable with a dark theme. - [#1640](https://github.com/plotly/dash/pull/1640) Fix [#1475](https://github.com/plotly/dash/issues/1475), missing `timing_information` after certain modifications to Flask behavior ## [1.20.0] - 2021-04-08