analytics: remove Google Analytics in favor of Google Tag Manager #343

VeraZab · 2019-10-29T17:46:52Z

As per conversation here: https://github.com/plotly/marketing-team/issues/118#issuecomment-542334742

We'd like to put the Google Tag Manager script into our dash-sample-apps instead of using GA only.

GTM includes such tracking codes like Pardot, which the marketing team would find useful to add on the apps.

Paste this code as high in the <head> of the page as possible:

<!-- Google Tag Manager -->
<script>(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],
j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=
'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);
})(window,document,'script','dataLayer','GTM-N6T2RXG');</script>
<!-- End Google Tag Manager -->

Additionally, paste this code immediately after the opening <body> tag:

<!-- Google Tag Manager (noscript) -->
<noscript><iframe src="https://www.googletagmanager.com/ns.html?id=GTM-N6T2RXG"
height="0" width="0" style="display:none;visibility:hidden"></iframe></noscript>
<!-- End Google Tag Manager (noscript) -->

The text was updated successfully, but these errors were encountered:

ycaokris · 2019-11-07T21:38:45Z

We have an app-loading problem in executing gunicorn app:server after inserting above script in app.index_string.

#351 modifies predeploy.py to add the following content inside app.py right above if __name__ == "__main__":

app.index_string = '''<!DOCTYPE html>
<html>
    <head>
    {%metas%}
        <title>{%title%}</title>
        {%favicon%}
        {%css%}
        <script>(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src='https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);})(window,document,'script','dataLayer','GTM-N6T2RXG');</script>
    </head>
    <body>
<noscript><iframe src="https://www.googletagmanager.com/ns.html?id=GTM-N6T2RXG"
height="0" width="0" style="display:none;visibility:hidden"></iframe></noscript>
        {%app_entry%}
        <footer>
            {%config%}
            {%scripts%}
            {%renderer%}
        </footer>
    </body>
</html>
'''

This has successfully loaded the script inside app. When I run python app.py locally, script in is being loaded, and tracked by pardot.

However running gunicorn app:server has resulted in app fail loading, and we noticed that all dash_renderer loading js has been wrongly replaced by this index string(screenshot below).

This problem doesn't exist with running before editing index_string. I'm not sure whether it's a deployment-only issue, or related with dash-render, will further investigate with @Marc-Andre-Rivet or @byronz

shammamah-zz · 2019-11-07T21:48:36Z

Funnily enough, I'm running into this issue as well when I try to run my dash_bio integration tests locally.

ycaokris · 2019-11-07T22:10:36Z

Updates

The app loading problem we had above with gunicorn is not due to insertion of index string. We define a env variable export DASH_APP_NAME=dash-drug-precursor before gunicorn app.py and it turned out this env has caused app error. Once this variable is cleared, app could be loaded without any problem. Verified by running the same workflow with apps not changed.

Here with gunicorn command, script and body has been inserted with GTM script we want

ycaokris · 2019-11-11T20:40:59Z

#353 deployed on https://dash-playground.plotly.host/dash-drug-discovery/ for a functional check.

lundstrj · 2019-12-10T17:30:18Z

@VeraZab @ycaokris bump. Is this still a relevant issue we should keep around or has the world already moved on past it?

VeraZab · 2019-12-10T17:43:48Z

well, I haven't had a chance to test this working, @ycaokris , is this ready to test on gallery?

VeraZab · 2019-12-10T17:45:46Z

personally, i still see the old analytics code on our gallery apps, do we have an estimate of when i could test the new gtm tag?

ycaokris · 2019-12-10T19:53:03Z

well, I haven't had a chance to test this working, @ycaokris , is this ready to test on gallery?

Not for batch deploy yet due to gallery sizing limit, I've ran manually for oil-and-gas and drug discovery and blocked by disk space issue. https://github.com/plotly/streambed/issues/13854 needs to be ran rather than manual deploy, will be worked on today and I'll update when all gal apps are re-deployed.

lundstrj · 2019-12-10T20:04:35Z

Sounds like it's still relevant. Let's see if we can get it across the finish line.

ycaokris · 2019-12-18T18:33:15Z

Updates on this issue:

With #366 , we've updated new GA tag for 31/49 python apps on gallery.

Still needs to work on:

Two remaining python apps not yet merged in the dash-sample-app
This should be auto-enabled when we complete merging all PRs WIP.

#135
#368

13 Dash-bio apps from https://github.com/plotly/dash-bio, @josegonzalez
Two dashr app: NCBI-Explorer and Uber NYC Rasterizer.
Right now inserting index string in dashR app hasn't been enabled (see https://github.com/plotly/streambed/issues/11962). I'm not sure whether asset loading as GA.js

function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],
j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=
'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);
})(window,document,'script','dataLayer','GTM-N6T2RXG')

would make it work so we may not get it in header, instead, will be in footer. Talked with @rpkyle and he'll test it out.

ycaokris · 2020-01-13T16:55:56Z

Follow up on this issue:

With #366 , we've updated new GA tag for 31/49 python apps on gallery.

Still needs to work on:

Two remaining python apps not yet merged in the dash-sample-app
This should be auto-enabled when we complete merging all PRs WIP.

#135
#368

All non-bio python apps have been merged and GA tag up-to-date.

13 Dash-bio apps from https://github.com/plotly/dash-bio, @josegonzalez

Gallery updates for bio apps will be completing within this week.

Two dashr app: NCBI-Explorer and Uber NYC Rasterizer.
Right now inserting index string in dashR app hasn't been enabled (see plotly/streambed#11962). I'm not sure whether asset loading as GA.js
function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],
j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=
'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);
})(window,document,'script','dataLayer','GTM-N6T2RXG')
would make it work so we may not get it in header, instead, will be in footer.

Currently work-in-progress by @HammadTheOne in #395

ycaokris · 2020-01-28T15:47:03Z

Updated status on GTM tag on gallery apps:

All python apps on https://dash-gallery.plotly.host/Portal/, including dash-bio apps have been refreshed with new GTM tag.
Two remaining DashR apps to go: NCBI Explorer and Uber rasterizer. This will be added after index_string is supported expected in dashR 0.3.0, in Add GTM tags to DashR apps #395

lundstrj · 2020-02-04T20:23:10Z

Is this connected to https://github.com/plotly/marketing-team/issues/148?

ycaokris · 2020-02-05T01:46:14Z

All gallery apps except dash-R done. Closing this in favor of progress track in https://github.com/plotly/marketing-team/issues/148

VeraZab mentioned this issue Oct 29, 2019

analytics: add google tag manager plotly/dash-bio#435

Closed

ycaokris assigned shammamah-zz and ycaokris Oct 29, 2019

bpostlethwaite added the Solutions: backlog label Oct 29, 2019

shammamah-zz mentioned this issue Nov 7, 2019

Add new Google Analytics tags to each app before deployment. #351

Merged

bpostlethwaite removed the Solutions: backlog label Dec 11, 2019

ycaokris assigned rpkyle Dec 18, 2019

ycaokris assigned HammadTheOne and unassigned rpkyle Jan 28, 2020

ycaokris closed this as completed Feb 5, 2020

ycaokris mentioned this issue Feb 18, 2020

Add GTM tags to DashR apps #395

Closed

rpkyle unassigned shammamah-zz, HammadTheOne and ycaokris May 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

analytics: remove Google Analytics in favor of Google Tag Manager #343

analytics: remove Google Analytics in favor of Google Tag Manager #343

VeraZab commented Oct 29, 2019 •

edited

Loading

ycaokris commented Nov 7, 2019 •

edited

Loading

shammamah-zz commented Nov 7, 2019

ycaokris commented Nov 7, 2019

ycaokris commented Nov 11, 2019

lundstrj commented Dec 10, 2019

VeraZab commented Dec 10, 2019

VeraZab commented Dec 10, 2019

ycaokris commented Dec 10, 2019

lundstrj commented Dec 10, 2019

ycaokris commented Dec 18, 2019 •

edited

Loading

ycaokris commented Jan 13, 2020 •

edited

Loading

ycaokris commented Jan 28, 2020

lundstrj commented Feb 4, 2020

ycaokris commented Feb 5, 2020

analytics: remove Google Analytics in favor of Google Tag Manager #343

analytics: remove Google Analytics in favor of Google Tag Manager #343

Comments

VeraZab commented Oct 29, 2019 • edited Loading

ycaokris commented Nov 7, 2019 • edited Loading

shammamah-zz commented Nov 7, 2019

ycaokris commented Nov 7, 2019

ycaokris commented Nov 11, 2019

lundstrj commented Dec 10, 2019

VeraZab commented Dec 10, 2019

VeraZab commented Dec 10, 2019

ycaokris commented Dec 10, 2019

lundstrj commented Dec 10, 2019

ycaokris commented Dec 18, 2019 • edited Loading

ycaokris commented Jan 13, 2020 • edited Loading

ycaokris commented Jan 28, 2020

lundstrj commented Feb 4, 2020

ycaokris commented Feb 5, 2020

VeraZab commented Oct 29, 2019 •

edited

Loading

ycaokris commented Nov 7, 2019 •

edited

Loading

ycaokris commented Dec 18, 2019 •

edited

Loading

ycaokris commented Jan 13, 2020 •

edited

Loading