-
Notifications
You must be signed in to change notification settings - Fork 33
Request Queue Size Unbounded #27
Comments
Thanks for reporting! I'll look into this today. |
@ajspeck - I've pushed up a preliminary fix in the prerelease channel. Could you try it out with:
This will fix the boundless Thanks!! |
The updated version fixes the performance issues I saw before. Watching the requestQueue size over 30 minutes, I saw it stayed fixed at around 40 items with none of the growth I saw before. Thanks for getting this fixed quickly. |
Thank you @ajspeck ! I'll work on getting this into the stable branch soon. In the meantime, it should be "safe" for you to use this prerelease channel. |
Fixed in #28 and available in a stable channel at |
The changes in #22 cause the request queue to continuously grow as new updates come in since old requests are only marked as rejected and not removed from the list. Once this array reaches a couple of hundred items long, I see Chrome and Firefox slow to a crawl. Note the growth of the array is easily visible in the SET_REQUEST_QUEUE action logged in the browser console. For my app this occurs in a couple of seconds given the number of updates being made.
Adding this:
to the updateRequestQueue function
dash-renderer/src/actions/index.js
Lines 397 to 411 in 401b977
fixed the performance issue I saw but it is not clear that this is the best solution.
The text was updated successfully, but these errors were encountered: