Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation: Show current position in navigation #1257

Closed
1 of 2 tasks
ksuess opened this issue May 24, 2022 · 4 comments · Fixed by #1339
Closed
1 of 2 tasks

Navigation: Show current position in navigation #1257

ksuess opened this issue May 24, 2022 · 4 comments · Fixed by #1339
Assignees
@ksuess
Labels
04 type: enhancement 99 tag: sprint 99 tag: theme Theme or Sphinx version change issues
Milestone
Plone 6.0

Comments

@ksuess
Copy link
Member

ksuess commented May 24, 2022

Plone Documentation versions affected

  • 5.x
  • 6.x

Description

Would be nice to have the current navigation entry in scope.
Example: https://6.dev-docs.plone.org/plone.api/api/content.html
grafik
@ksuess ksuess added this to the Plone 6.0 milestone May 24, 2022
@stevepiercy
Copy link
Contributor

I agree. Is there something that auto-scrolls the navigation pane in any of the base themes? I would assume that this problem has been identified with possible solutions already in their issue trackers.

@stevepiercy
Copy link
Contributor

This was fixed in the grandparent theme pydata/pydata-sphinx-theme#535.

Demo https://pydata-sphinx-theme.readthedocs.io/en/latest/demo/subpages/subsubpages/subsubpage20.html

This was incorporated in v0.3.2 of sphinx-book-theme, which we pinned to <=0.3.99, so it should work.

@ksuess ksuess moved this from New to Todo in Plone Documentation Aug 2, 2022
@ksuess ksuess self-assigned this Aug 30, 2022
@ksuess ksuess moved this from Todo to In Progress in Plone Documentation Sep 4, 2022
@ksuess ksuess changed the title Navigation: Show current position in naviagtion Navigation: Show current position in navigation Sep 4, 2022
@ksuess
Copy link
Member Author

ksuess commented Sep 4, 2022

Bug fix in sphinx-book-theme is submitted: executablebooks/sphinx-book-theme#609

@stevepiercy stevepiercy added the 99 tag: theme Theme or Sphinx version change issues label Sep 7, 2022
@ksuess
Copy link
Member Author

ksuess commented Oct 3, 2022 •
edited
Loading

Bug fix in sphinx-book-theme is submitted: executablebooks/sphinx-book-theme#609

Bug fix is merged, but no release so far. executablebooks/sphinx-book-theme#611
I'll make a patch here and in training.

@ksuess ksuess linked a pull request Oct 3, 2022 that will close this issue
Add patch scrollToActive (active main navigation item) #1339
Merged
@ksuess ksuess mentioned this issue Oct 3, 2022
Merged
Repository owner moved this from In Progress to Done in Plone Documentation Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ksuess ksuess

Labels
04 type: enhancement 99 tag: sprint 99 tag: theme Theme or Sphinx version change issues
Projects
Plone Documentation
Status: Done
Milestone
Plone 6.0
Development

Successfully merging a pull request may close this issue.

Add patch scrollToActive (active main navigation item) plone/documentation
2 participants
@stevepiercy @ksuess