fix: rely on latest arborist properties

dominykas · dominykas · commit 822efb44446a · 2021-05-03T17:59:58.000+03:00
This was introduced in 2.1.0, it breaks tests locally for whatever reason, but passes in CI. `isProjectRoot` also checks for "dep === dep.root.target", which I assume is the correct and desired behavior.
diff --git a/lib/deps.js b/lib/deps.js
@@ -31,7 +31,7 @@ internals.resolve = async ({ packageJson, lockfile }, options) => {
 
     for (const dep of arborist.idealTree.inventory.values()) {
 
-        if (dep.root === dep) {
+        if (dep.isProjectRoot) {
             // root node is not a dep, really
             continue;
         }
@@ -41,7 +41,7 @@ internals.resolve = async ({ packageJson, lockfile }, options) => {
             continue;
         }
 
-        if (!options.deep && ![...dep.edgesIn].some(({ from }) => from === arborist.idealTree)) {
+        if (!options.deep && ![...dep.edgesIn].some(({ from }) => from.isProjectRoot)) {
             continue;
         }
 
diff --git a/package.json b/package.json
@@ -36,7 +36,7 @@
   },
   "dependencies": {
     "@hapi/wreck": "^17.0.0",
-    "@npmcli/arborist": "^2.0.0",
+    "@npmcli/arborist": "^2.1.0",
     "@pkgjs/nv": "0.1.0",
     "debug": "^4.1.1",
     "git-url-parse": "^11.1.2",

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ internals.resolve = async ({ packageJson, lockfile }, options) => {`
`31`	`31`
`32`	`32`	`for (const dep of arborist.idealTree.inventory.values()) {`
`33`	`33`
`34`		`- if (dep.root === dep) {`
	`34`	`+ if (dep.isProjectRoot) {`
`35`	`35`	`// root node is not a dep, really`
`36`	`36`	`continue;`
`37`	`37`	`}`
`@@ -41,7 +41,7 @@ internals.resolve = async ({ packageJson, lockfile }, options) => {`
`41`	`41`	`continue;`
`42`	`42`	`}`
`43`	`43`
`44`		`- if (!options.deep && ![...dep.edgesIn].some(({ from }) => from === arborist.idealTree)) {`
	`44`	`+ if (!options.deep && ![...dep.edgesIn].some(({ from }) => from.isProjectRoot)) {`
`45`	`45`	`continue;`
`46`	`46`	`}`
`47`	`47`