Skip to content

Commit 49bcab2

Browse files
committed
chore: deprecate node 10 and 12
BREAKING CHANGE: dropping support for old versions of node. This is primarily because npm@8 no longer works on node@10, which complicates the CI scripts unnecessarily.
1 parent f4b0cfb commit 49bcab2

File tree

4 files changed

+16
-15
lines changed

4 files changed

+16
-15
lines changed

.travis.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
language: node_js
22

33
import:
4-
- nodejs/ci-config-travis:lts/gte-10.yml
4+
- nodejs/ci-config-travis:lts/gte-14.yml
55

66
cache:
77
npm: false

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"url": "https://github.com/pkgjs/detect-node-support/issues"
2525
},
2626
"engines": {
27-
"node": ">=10"
27+
"node": ">=14"
2828
},
2929
"homepage": "https://github.com/pkgjs/detect-node-support#readme",
3030
"devDependencies": {

test/fixtures/index.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,9 @@ module.exports = class TestContext {
7272

7373
Nock('https://api.github.com')
7474
.persist()
75-
.get('/repos/nodejs/ci-config-travis/contents/lts%2Fgte-10.yml')
75+
.get('/repos/nodejs/ci-config-travis/contents/lts%2Fgte-14.yml')
7676
.reply(200, {
77+
// note: this is mocked out to an earlier version of node, to avoid having to update too many assertions/fixtures
7778
content: Fs.readFileSync(Path.join(__dirname, 'travis-ymls', 'nodejs-ci-config-travis-gte-10.yml')).toString('base64')
7879
});
7980

test/index.js

+12-12
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ describe('detect-node-support', () => {
6262
'14': '14.3.0'
6363
}
6464
},
65-
engines: '>=10'
65+
engines: '>=14'
6666
});
6767
});
6868

@@ -454,7 +454,7 @@ describe('detect-node-support', () => {
454454
'14': '14.3.0'
455455
}
456456
},
457-
engines: '>=10'
457+
engines: '>=14'
458458
});
459459
});
460460

@@ -491,7 +491,7 @@ describe('detect-node-support', () => {
491491
'14': '14.3.0'
492492
}
493493
},
494-
engines: '>=10'
494+
engines: '>=14'
495495
});
496496
});
497497

@@ -518,7 +518,7 @@ describe('detect-node-support', () => {
518518
version: '0.0.0-development',
519519
commit: '9cef39d21ad229dea4b10295f55b0d9a83800b23',
520520
timestamp: 1580673602000,
521-
engines: '>=10'
521+
engines: '>=14'
522522
});
523523
});
524524

@@ -621,7 +621,7 @@ describe('detect-node-support', () => {
621621
'14': '14.3.0'
622622
}
623623
},
624-
engines: '>=10'
624+
engines: '>=14'
625625
});
626626
});
627627

@@ -686,7 +686,7 @@ describe('detect-node-support', () => {
686686
'14': '14.3.0'
687687
}
688688
},
689-
engines: '>=10'
689+
engines: '>=14'
690690
});
691691
});
692692

@@ -717,7 +717,7 @@ describe('detect-node-support', () => {
717717
version: '0.0.0-development',
718718
commit: '9cef39d21ad229dea4b10295f55b0d9a83800b23',
719719
timestamp: 1580673602000,
720-
engines: '>=10'
720+
engines: '>=14'
721721
});
722722
});
723723

@@ -815,7 +815,7 @@ describe('detect-node-support', () => {
815815
'14': '14.3.0'
816816
}
817817
},
818-
engines: '>=10'
818+
engines: '>=14'
819819
});
820820
});
821821

@@ -865,7 +865,7 @@ describe('detect-node-support', () => {
865865
'14': '14.3.0'
866866
}
867867
},
868-
engines: '>=10'
868+
engines: '>=14'
869869
});
870870
});
871871

@@ -902,7 +902,7 @@ describe('detect-node-support', () => {
902902
'14': '14.3.0'
903903
}
904904
},
905-
engines: '>=10'
905+
engines: '>=14'
906906
});
907907
});
908908

@@ -939,7 +939,7 @@ describe('detect-node-support', () => {
939939
'14': '14.3.0'
940940
}
941941
},
942-
engines: '>=10'
942+
engines: '>=14'
943943
});
944944
});
945945

@@ -980,7 +980,7 @@ describe('detect-node-support', () => {
980980
'14': '14.3.0'
981981
}
982982
},
983-
engines: '>=10'
983+
engines: '>=14'
984984
});
985985
});
986986

0 commit comments

Comments
 (0)