Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings item in Tools menu #1020

Closed
dogancelik opened this issue Jan 8, 2016 · 7 comments
Closed

Settings item in Tools menu #1020

dogancelik opened this issue Jan 8, 2016 · 7 comments

Comments

@dogancelik
Copy link

Optional Settings menu item in Tools menu would be really handy oppose to searching for Options button in Add-ons page.

tst

@piroor
Copy link
Owner

piroor commented Jan 15, 2016

I have no motivation to add such a menu item, sorry. See the comment: #940 (comment)

@dogancelik
Copy link
Author

Is there a function to open Settings dialog like below?

coomanPlus.openCookieEditor();
s3menuwizard.open_options_window();

So users can add the item themselves

@piroor
Copy link
Owner

piroor commented Jan 15, 2016

No such function. TST's configuration dialog is only shown by Firefox's addon manager - I entrust anything around the configuration dialog to Firefox itself, so I really don't know details how to do it manually. And I believe that it is not a task of addon authors.

@piroor
Copy link
Owner

piroor commented Jan 15, 2016

In other words, I don't want to treat how to open configuration dialogs by myself because the most well-mannered way to open configuration UI of addons can change on future versions of Firefox. I hope to spend more time to fix other critical bugs instead of maintaining such unnecessary codes.

@piroor
Copy link
Owner

piroor commented Jan 15, 2016

And, as my comments on the referred issue #940, if you are annoyed by something and you have to open TST's configuration dialog again and again, then the problem should be solved with any other method better than adding menu item to open the configuration dialog.

@dogancelik
Copy link
Author

Thank you for sharing your thoughts.

I found a way to open Settings dialog using S3 Menu Wizard

Steps

Create an item and put this code in onCommand event

openDialog('chrome://treestyletab/content/config.xul', '', 'chrome,titlebar,toolbar,centerscreen,modal');

and use this CSS to change the icon of the menu item:

list-style-image: url('chrome://treestyletab/content/res/icon.png');

Result

result

Hope this helps people with the same request :)

@piroor
Copy link
Owner

piroor commented Jan 16, 2016

Thanks!

@piroor piroor closed this as completed Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants