Skip to content

Commit 2194b9e

Browse files
committed
Deactivate "hide inactive tabs" feature.
Due to mozilla/addons-linter#1788 we cannot release a version with "tabHide" permission.
1 parent 157d508 commit 2194b9e

File tree

5 files changed

+11
-2
lines changed

5 files changed

+11
-2
lines changed

webextensions/manifest.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@
1717
],
1818
"optional_permissions": [
1919
"<all_urls>",
20-
"bookmarks",
21-
"tabHide"
20+
"bookmarks"
2221
],
2322
"icons": {
2423
"16": "resources/16x16-light.svg",

webextensions/options/init.js

+2
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,12 @@ window.addEventListener('DOMContentLoaded', () => {
3838
Permissions.BOOKMARKS,
3939
document.querySelector('#bookmarksPermissionGranted')
4040
);
41+
/*
4142
Permissions.bindToCheckbox(
4243
Permissions.TAB_HIDE,
4344
document.querySelector('#tabHidePermissionGranted')
4445
);
46+
*/
4547

4648
options.buildUIForAllConfigs(document.querySelector('#debug-configs'));
4749
onConfigChanged('debug');

webextensions/options/options.html

+4
Original file line numberDiff line numberDiff line change
@@ -90,12 +90,14 @@ <h1>__MSG_config.appearance.caption__</h1>
9090
<p><label><input id="showContextualIdentitiesSelector"
9191
type="checkbox">
9292
__MSG_config.showContextualIdentitiesSelector.label__</label></p>
93+
<!--
9394
<p><label><input id="hideInactiveTabs"
9495
type="checkbox">
9596
__MSG_config.hideInactiveTabs.label__</label></p>
9697
<p class="sub"><label><input id="tabHidePermissionGranted"
9798
type="checkbox">
9899
__MSG_config.requestPermissions.tabHide__</label></p>
100+
-->
99101
<p><label><input id="animation"
100102
type="checkbox">
101103
__MSG_config.animation.label__</label></p>
@@ -393,9 +395,11 @@ <h1>__MSG_config.debug.caption__</h1>
393395
name="sidebarScrollbarPosition" value="2">
394396
__MSG_config.sidebarScrollbarPosition.right__</label>
395397
</p>
398+
<!--
396399
<p><label><input id="preventUnexpectedFocusToLastPinnedTabForClosedCurrentTab"
397400
type="checkbox">
398401
__MSG_config.preventUnexpectedFocusToLastPinnedTabForClosedCurrentTab.label__</label></p>
402+
-->
399403
<h2>__MSG_config.all.caption__</h2>
400404
</div>
401405
</body>

webextensions/resources/startup.html

+2
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,12 @@ <h1 id="title">__MSG_extensionName__</h1>
117117
<label><input id="allUrlsPermissionGranted"
118118
type="checkbox">
119119
__MSG_message.startup.requestPermissions.allUrls__</label></p>
120+
<!--
120121
<p class="checkbox">
121122
<label><input id="tabHidePermissionGranted"
122123
type="checkbox">
123124
__MSG_message.startup.requestPermissions.tabHide__</label></p>
125+
-->
124126
</div>
125127

126128
<div class="user-chrome-css">

webextensions/resources/startup.js

+2
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ window.addEventListener('DOMContentLoaded', () => {
1717
Permissions.BOOKMARKS,
1818
document.querySelector('#bookmarksPermissionGranted')
1919
);
20+
/*
2021
Permissions.bindToCheckbox(
2122
Permissions.TAB_HIDE,
2223
document.querySelector('#tabHidePermissionGranted'),
@@ -27,4 +28,5 @@ window.addEventListener('DOMContentLoaded', () => {
2728
}
2829
}
2930
);
31+
*/
3032
}, { once: true });

0 commit comments

Comments
 (0)