Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: migrate stale_txn tests to real tikv tests #59589

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

ekexium
Copy link
Member

@ekexium ekexium commented Feb 17, 2025

What problem does this PR solve?

Issue Number: close #59588

Problem Summary:

See the issue.

What changed and how does it work?

  1. Migrate tests from stale_txn_test.go to real tikv tests.
  2. Add a new case to reproduce TSO retrieval failure during read TS validation caused by residual txn-scope code #59402

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 17, 2025
@ekexium ekexium force-pushed the real-tikv-stale-read-test branch from fbff83e to b59a832 Compare February 17, 2025 11:37
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium ekexium force-pushed the real-tikv-stale-read-test branch from b59a832 to cb2ca90 Compare February 17, 2025 11:42
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5960%. Comparing base (1596775) to head (2b3a5ff).
Report is 15 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59589        +/-   ##
================================================
+ Coverage   73.0272%   73.5960%   +0.5687%     
================================================
  Files          1694       1694                
  Lines        468332     473016      +4684     
================================================
+ Hits         342010     348121      +6111     
+ Misses       105323     103786      -1537     
- Partials      20999      21109       +110     
Flag Coverage Δ
integration 42.8724% <100.0000%> (?)
unit 72.4067% <100.0000%> (+0.1681%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7084% <ø> (+0.4885%) ⬆️

Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 19, 2025
Copy link

ti-chi-bot bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 19, 2025
Copy link

ti-chi-bot bot commented Feb 19, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-19 07:41:14.639661893 +0000 UTC m=+1033517.035883948: ☑️ agreed by zyguan.
  • 2025-02-19 07:54:00.245355334 +0000 UTC m=+1034282.641577389: ☑️ agreed by cfzjywxk.

@ti-chi-bot ti-chi-bot bot merged commit 9b8296b into pingcap:master Feb 19, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests of stale-read should use real TiKV
3 participants