Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Update client-go and verify all read ts #58923

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

ekexium
Copy link
Member

@ekexium ekexium commented Jan 14, 2025

What problem does this PR solve?

Issue Number: ref #57786

Problem Summary:

What changed and how does it work?

Cherry pick #58054

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Strengthen timestamp validation checks.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 14, 2025
@ekexium
Copy link
Member Author

ekexium commented Jan 14, 2025

/retest

@ekexium ekexium force-pushed the release-8.1-validate-ts branch 4 times, most recently from 20b540b to 65e833c Compare January 15, 2025 03:43
@ekexium ekexium force-pushed the release-8.1-validate-ts branch from 65e833c to 58ea378 Compare January 15, 2025 04:30
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium ekexium force-pushed the release-8.1-validate-ts branch from d8389a8 to 1ee748e Compare January 15, 2025 06:05
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@50a5149). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #58923   +/-   ##
================================================
  Coverage               ?   71.2533%           
================================================
  Files                  ?       1468           
  Lines                  ?     423986           
  Branches               ?          0           
================================================
  Hits                   ?     302104           
  Misses                 ?     101358           
  Partials               ?      20524           
Flag Coverage Δ
unit 71.2533% <84.6153%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.3645% <0.0000%> (?)

@ekexium ekexium requested review from zyguan and MyonKeminta January 15, 2025 07:03
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 15, 2025
@ekexium ekexium requested a review from qw4990 January 16, 2025 04:39
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 16, 2025
Copy link

ti-chi-bot bot commented Jan 16, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-15 07:15:20.174758747 +0000 UTC m=+102791.629804896: ☑️ agreed by zyguan.
  • 2025-01-16 11:05:57.458103317 +0000 UTC m=+203028.913149465: ☑️ agreed by MyonKeminta.

Copy link

ti-chi-bot bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MyonKeminta, qw4990, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 16, 2025
@ekexium
Copy link
Member Author

ekexium commented Jan 16, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit f2f8d42 into pingcap:release-8.1 Jan 16, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants