Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests of stale-read should use real TiKV #59588

Closed
ekexium opened this issue Feb 17, 2025 · 0 comments · Fixed by #59589
Closed

Unit tests of stale-read should use real TiKV #59588

ekexium opened this issue Feb 17, 2025 · 0 comments · Fixed by #59589
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@ekexium
Copy link
Member

ekexium commented Feb 17, 2025 •
edited
Loading

Enhancement

Unit tests of stale-read should use real TiKV to expose potential problems when interacting with PD or PD client, especially when it's related to txn scope or read replica scope.

#59402 could have been detected earlier by unit tests if we've done so before.
@ekexium ekexium added the type/enhancement The issue or PR belongs to an enhancement. label Feb 17, 2025
@ekexium ekexium mentioned this issue Feb 17, 2025
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Feb 19, 2025
@ekexium
*: migrate stale_txn tests to real tikv tests (#59589)
9b8296b 
close #59588
@ekexium ekexium mentioned this issue Feb 24, 2025
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: migrate stale_txn tests to real tikv tests ekexium/tidb
1 participant
@ekexium