Skip to content
This repository has been archived by the owner on Jan 3, 2025. It is now read-only.

[2.0.4] dmctl: support read master addr from env (#691) #710

Merged
merged 1 commit into from
Jun 21, 2021
Merged

[2.0.4] dmctl: support read master addr from env (#691) #710

merged 1 commit into from
Jun 21, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #691

What is changed, added, or deleted? (Required)

update dmctl doc to note that master_addr can be read from env var.

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v3.0 changes)
  • v2.0 (TiDB DM 2.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Change aliases

@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-2.0 This PR is cherry-picked to release-2.0 from a source PR. labels Jun 21, 2021
@ti-chi-bot ti-chi-bot requested a review from lichunzhu June 21, 2021 04:29
@ti-chi-bot ti-chi-bot requested a review from CharLotteiu June 21, 2021 04:29
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharLotteiu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2021
@CharLotteiu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: da49a18

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2021
@ti-chi-bot ti-chi-bot merged commit 31a3adb into pingcap:release-2.0 Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-2.0 This PR is cherry-picked to release-2.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants