Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

feat: manual cherry merge PR #633 to release-1.0 #676

Merged
merged 3 commits into from
May 22, 2020
Merged

feat: manual cherry merge PR #633 to release-1.0 #676

merged 3 commits into from
May 22, 2020

Conversation

Kuri-su
Copy link
Contributor

@Kuri-su Kuri-su commented May 20, 2020

What is changed and how it works?

manual cherry merge PR #633 to release-1.0

@sre-bot sre-bot added the contribution For contributor label May 20, 2020
@Kuri-su
Copy link
Contributor Author

Kuri-su commented May 21, 2020

/run-all-tests

@codecov
Copy link

codecov bot commented May 21, 2020 •
edited
Loading

Codecov Report

Merging #676 into release-1.0 will increase coverage by 0.0191%.
The diff coverage is 35.0000%.

@@                 Coverage Diff                 @@
##           release-1.0       #676        +/-   ##
===================================================
+ Coverage      57.8452%   57.8643%   +0.0191%     
===================================================
  Files              166        166                
  Lines            17004      16988        -16     
===================================================
- Hits              9836       9830         -6     
+ Misses            6212       6200        -12     
- Partials           956        958         +2

@Kuri-su
Copy link
Contributor Author

Kuri-su commented May 21, 2020

@csuzhangxc ok, i'm done , PTAL 😄

csuzhangxc
csuzhangxc reviewed May 21, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@csuzhangxc csuzhangxc added needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer type/feature New feature labels May 21, 2020
@csuzhangxc csuzhangxc added this to the v1.0.6 milestone May 21, 2020
@Kuri-su Kuri-su requested a review from csuzhangxc May 21, 2020 09:37
csuzhangxc
csuzhangxc reviewed May 21, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added the status/LGT1 One reviewer already commented LGTM label May 21, 2020
@csuzhangxc csuzhangxc requested a review from WangXiangUSTC May 21, 2020 14:21
WangXiangUSTC
WangXiangUSTC approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels May 22, 2020
@csuzhangxc csuzhangxc merged commit 6a5d369 into pingcap:release-1.0 May 22, 2020
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated already-update-docs The docs related to this PR already updated. Add this label once the docs are updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Jun 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

Assignees
No one assigned
Labels
already-update-docs The docs related to this PR already updated. Add this label once the docs are updated already-update-release-note The release note is updated. Add this label once the release note is updated contribution For contributor priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/feature New feature
Projects
None yet
Milestone
v1.0.6
Development

Successfully merging this pull request may close these issues.
4 participants
@Kuri-su @csuzhangxc @WangXiangUSTC @sre-bot