-
Notifications
You must be signed in to change notification settings - Fork 188
syncer: fix the case-sensitive issue (#1738) #1886
syncer: fix the case-sensitive issue (#1738) #1886
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
/run-all-tests |
merge conflict in tests/others_integration.txt |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 632e524
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #1738
What problem does this PR solve?
Fix the bug that
case-sensitive
can not take effect as expected.What is changed and how it works?
lower_case_table_names
setting at bootstrap, do not allow setcase-sensitive = true
whenlower_case_table_names = true
lower_case_table_names
, return Name.O for 0, and Name.L for 1/2.lower_case_table_names = 0
Check List
Tests
Code changes
Side effects
lower_case_table_names = 0
, we can't rollback to the origin version since some persistent data has been changed.Related changes