Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dmctl: try read master addr from env (#1722) #1726

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1722

What problem does this PR solve?

#1720

What is changed and how it works?

as title

Check List

Tests

  • Unit test
  • Integration test

Code changes

-None

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@ti-chi-bot ti-chi-bot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/M status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick-for-release-2.0 labels May 27, 2021
@ti-chi-bot ti-chi-bot requested a review from glorv May 27, 2021 02:58
@ti-chi-bot ti-chi-bot requested review from GMHDBJD and lichunzhu May 27, 2021 02:58
@GMHDBJD GMHDBJD added the needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated label May 27, 2021
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please remember to update docs about this feature. @Ehco1996

Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label May 27, 2021
@GMHDBJD GMHDBJD added the require-LGT1 for small PR, LGT1 is enough label May 27, 2021
@GMHDBJD
Copy link
Collaborator

GMHDBJD commented May 27, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 392711c

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated require-LGT1 for small PR, LGT1 is enough size/M status/can-merge status/LGT1 One reviewer already commented LGTM status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick-for-release-2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants