-
Notifications
You must be signed in to change notification settings - Fork 188
dmctl: try read master addr from env (#1722) #1726
dmctl: try read master addr from env (#1722) #1726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please remember to update docs about this feature. @Ehco1996
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 392711c
|
This is an automated cherry-pick of #1722
What problem does this PR solve?
#1720
What is changed and how it works?
as title
Check List
Tests
Code changes
-None
Side effects
Related changes