Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

loader: revert #1544 to reduce risks #1657

Merged
merged 2 commits into from
May 8, 2021
Merged

loader: revert #1544 to reduce risks #1657

merged 2 commits into from
May 8, 2021

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

We need to release v2.0.3 recently. Some improvement PRs will be reverted to reduce the risk of bugs.

What is changed and how it works?

revert #1544

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Possible performance regression

@ti-chi-bot ti-chi-bot requested review from GMHDBJD and lance6716 May 7, 2021 08:26
@lichunzhu lichunzhu changed the title revert #1544 to reduce risks loader: revert #1544 to reduce risks May 7, 2021
@GMHDBJD
Copy link
Collaborator

GMHDBJD commented May 7, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label May 7, 2021
@lance6716
Copy link
Collaborator

and we should revert this "revert PR" once v2.0.3 is released?

(will review later)

@lichunzhu
Copy link
Contributor Author

and we should revert this "revert PR" once v2.0.3 is released?

(will review later)

Yes

@glorv
Copy link
Collaborator

glorv commented May 7, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels May 7, 2021
@lance6716 lance6716 added this to the v2.0.3 milestone May 8, 2021
@lichunzhu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f31d5dc

@lichunzhu lichunzhu added the needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 label May 8, 2021
@ti-chi-bot ti-chi-bot merged commit 2707ad5 into pingcap:release-2.0 May 8, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: base branch (release-2.0) needs to differ from target branch (release-2.0).

@lichunzhu lichunzhu deleted the revertPR1544 branch May 8, 2021 07:28
@lichunzhu lichunzhu removed the needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 label May 8, 2021
lance6716 added a commit that referenced this pull request May 12, 2021
@lance6716
Revert "loader: revert #1544 to reduce risks (#1657)"
94d0acb 
This reverts commit 2707ad5.
This was referenced May 12, 2021
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
size/XL status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Milestone
v2.0.3
Development

Successfully merging this pull request may close these issues.
5 participants
@lichunzhu @GMHDBJD @lance6716 @glorv @ti-chi-bot