This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
dmctl, scheduler: support manually transfer-source #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
added
needs-cherry-pick-release-2.0
|
Maybe |
OK, I haven't add dmctl part |
so I prefer |
lance6716
changed the title
lichunzhu
reviewed
Mar 12, 2021
| failpoint.Inject("failToReplaceSourceBound", func(_ failpoint.Value) { | ||
| failpoint.Return(errors.New("failToPutSourceBound")) | ||
| }) | ||
| _, err := ha.ReplaceSourceBound(s.etcdCli, source, oldWorker.BaseInfo().Name, worker) |
There was a problem hiding this comment.
Is there any problem when the last worker doesn't stop its own source timely?
There was a problem hiding this comment.
Delete source bound can't handle it? If so, we may have the same problem when there is a network isolation between worker and master.
|
/lgtm |
|
going to stop transfer when there's running subtask on it, to avoid new and old worker both online |
lichunzhu
added
the
status/DNM
lance6716
removed
the
status/DNM
|
/run-all-tests |
|
/lgtm |
ti-srebot
pushed a commit
to ti-srebot/dm
that referenced
this pull request
Mar 12, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-2.0 in PR #1509 |
ti-srebot
added
already-cherry-pick-2.0
lance6716
pushed a commit
that referenced
this pull request
Mar 12, 2021
7 tasks
7 tasks
lance6716
removed
the
needs-update-docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #1075
What is changed and how it works?
support transfer a source to a free worker by
transfer-source -s <sourc-id> -w <worker-id>Check List
Tests
Code changes
Side effects
Related changes