Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer, relay: support incremental task with gtid specified only #1393

Merged
merged 6 commits into from
Jan 26, 2021

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Jan 20, 2021

What problem does this PR solve?

close #1391

What is changed and how it works?

don't update active relay log (only used for relay log purging?) when there's no binlog name which may because user only specifiy gtid only. Active relay log will be updated at heartbeat or DDL event with valid binlog name afterwards.

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@lance6716 lance6716 added status/WIP This PR is still work in progress needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Jan 20, 2021
@lance6716 lance6716 added this to the v2.0.2 milestone Jan 20, 2021
@lance6716 lance6716 added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels Jan 20, 2021
@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716
Copy link
Collaborator Author

/run-compatibility-test

Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jan 21, 2021
@lance6716
Copy link
Collaborator Author

PTAL @3pointer @amyangfei

Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716 lance6716 merged commit bf56fa3 into pingcap:master Jan 26, 2021
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Jan 26, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1401

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Jan 26, 2021
lance6716 pushed a commit that referenced this pull request Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated status/LGT1 One reviewer already commented LGTM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't start an incremental task with GTID specified only when relay enabled
4 participants