This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
syncer, relay: support incremental task with gtid specified only #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
/run-compatibility-test |
GMHDBJD
reviewed
Jan 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PTAL @3pointer @amyangfei |
3pointer
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
pushed a commit
to ti-srebot/dm
that referenced
this pull request
Jan 26, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-2.0 in PR #1401 |
lance6716
pushed a commit
that referenced
this pull request
Jan 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
already-cherry-pick-2.0
The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked
needs-update-release-note
This PR should be added into release notes. Remove this label once the release notes are updated
status/LGT1
One reviewer already commented LGTM
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #1391
What is changed and how it works?
don't update active relay log (only used for relay log purging?) when there's no binlog name which may because user only specifiy gtid only. Active relay log will be updated at heartbeat or DDL event with valid binlog name afterwards.
Check List
Tests
Code changes
Side effects
Related changes