Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

task_checker: don't resume for binlog not found (#1210) #1216

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1210 to release-2.0


What problem does this PR solve?

[2020/10/23 02:03:41.082 +00:00] [ERROR] [subtask.go:295] ["unit process error"] [subtask=test-all] [unit=Sync] ["error information"="{\"ErrCode\":50000,\"ErrClass\":\"not-set\",\"ErrScope\":\"not-set\",\"ErrLevel\":\"high\",\"Message\":\"ERROR 1236 (HY000): Could not find first log file name in binary log index file\"}"]
[2020/10/23 02:03:45.882 +00:00] [WARN] [task_checker.go:315] ["backoff skip auto resume task"] [component="task checker"] [task=test-all] [latestResumeTime=2020/10/23 02:03:40.882 +00:00] [duration=5m0s]

What is changed and how it works?

don't resume it

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added priority/unimportant Really minor change, requires approval from secondary reviewers type/cherry-pick This PR is just a cherry-pick (backport) first-time-contributor labels Oct 23, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc merged commit 8a9e5c2 into pingcap:release-2.0 Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
first-time-contributor priority/unimportant Really minor change, requires approval from secondary reviewers type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants