Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

UCP: Support both encrypted and unencrypted passwords for the upstream and downstream database #506

Closed
csuzhangxc opened this issue Mar 2, 2020 · 5 comments · Fixed by #633
Labels
difficulty/medium type/feature-request This issue is a feature request

Comments

@csuzhangxc
Copy link
Member

csuzhangxc commented Mar 2, 2020

Feature Request

Is your feature request related to a problem? Please describe:

Both encrypted and unencrypted passwords (by dmctl) are supported.

Describe the feature you'd like:

Support to pass both encrypted and unencrypted passwords (by dmctl) for the upstream and downstream database.

Score

600

Mentor(s)

Contact the mentors: #tidb-challenge-program channel in TiDB Community Slack Workspace

Recommended Skills

  • Golang
  • Experience with DM

Learning Materials

@csuzhangxc csuzhangxc added type/feature-request This issue is a feature request difficulty/medium labels Mar 2, 2020
@csuzhangxc csuzhangxc changed the title Support both encrypted and unencrypted passwords for the upstream and downstream database UCP: Support both encrypted and unencrypted passwords for the upstream and downstream database Mar 2, 2020
@Kuri-su
Copy link
Contributor

Kuri-su commented Apr 22, 2020

/pick-up-challenge

@sre-bot
Copy link

sre-bot commented Apr 22, 2020

@Kuri-su pick up issue success

@Kuri-su
Copy link
Contributor

Kuri-su commented Apr 22, 2020

Do i need to support like this?

$ dmctl --decrypt xxxxxxxxxxxxxxxxxxxxxxxxxxx
mypassword

but i don't know what's mean about "for the upstream and downstream database" in title 😂

@csuzhangxc
Copy link
Member Author

csuzhangxc commented Apr 23, 2020

Do i need to support like this?

$ dmctl --decrypt xxxxxxxxxxxxxxxxxxxxxxxxxxx
mypassword

but i don't know what's mean about "for the upstream and downstream database" in title 😂

@Kuri-su I mean, both encrypted or plaintext passwords are accepted in source.toml and task.yaml.

"upstream database" means passwords for the upstream/source MySQL instances, and "downstream database" means passwords for the downstream/target TiDB.

@Kuri-su
Copy link
Contributor

Kuri-su commented Apr 23, 2020

Do i need to support like this?

$ dmctl --decrypt xxxxxxxxxxxxxxxxxxxxxxxxxxx
mypassword

but i don't know what's mean about "for the upstream and downstream database" in title joy

@Kuri-su I mean, both encrypted or plaintext passwords are accepted in source.toml and task.yaml.

"upstream database" means passwords for the upstream/source MySQL instances, and "downstream database" means passwords for the downstream/target TiDB.

ok, i got it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
difficulty/medium type/feature-request This issue is a feature request
Projects
None yet
3 participants