Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

check grafana metrics and alter manager will send alert even if all DM master down #1419

Closed
lance6716 opened this issue Feb 2, 2021 · 1 comment
Closed

check grafana metrics and alter manager will send alert even if all DM master down #1419

lance6716 opened this issue Feb 2, 2021 · 1 comment
Labels
type/feature-request This issue is a feature request

Comments

@lance6716
Copy link
Collaborator

Feature Request

Is your feature request related to a problem? Please describe:

now DM masters are sources to send metrics to prometheus. when DM masters are all down, this is of course a disaster but may not inform user in time.

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:
@lance6716 lance6716 added the type/feature-request This issue is a feature request label Feb 2, 2021
@lance6716
Copy link
Collaborator Author

lance6716 commented Feb 3, 2021 •
edited
Loading

  • when all DM master is down, should alert
  • Any blocking goroutine should not block alerting
  • test current alert rules should work under multiple task per source

@lance6716 lance6716 changed the title check alter manager will send alert even if all DM master down check grafana metrics and alter manager will send alert even if all DM master down Feb 18, 2021
@lance6716 lance6716 mentioned this issue Feb 18, 2021
Merged
@ti-srebot ti-srebot mentioned this issue Feb 20, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/feature-request This issue is a feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lance6716