Skip to content

Commit

Permalink
ci: fix errors in ci github action for node 8 and 9 (#48)
Browse files Browse the repository at this point in the history
* Update ci.yml

* ci: add support for node@21

* ci: fix configure npm

* ci: upgrade actions/checkout to v4

* ci: add support for node@22

---------

Co-authored-by: Wes Todd <wes@wesleytodd.com>
  • Loading branch information
inigomarquinez and wesleytodd authored Aug 17, 2024
1 parent d51e533 commit eada099
Showing 1 changed file with 30 additions and 5 deletions.
35 changes: 30 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,12 @@ jobs:
- Node.js 15.x
- Node.js 16.x
- Node.js 17.x

- Node.js 18.x
- Node.js 19.x
- Node.js 20.x
- Node.js 21.x
- Node.js 22.x

include:
- name: Node.js 0.8
node-version: "0.8"
Expand Down Expand Up @@ -81,7 +86,7 @@ jobs:

- name: Node.js 8.x
node-version: "8.16"
npm-i: mocha@7.2.0 nyc@14.1.1
npm-i: mocha@7.2.0 nyc@14.1.1

- name: Node.js 9.x
node-version: "9.11"
Expand Down Expand Up @@ -115,8 +120,23 @@ jobs:
- name: Node.js 17.x
node-version: "17.9"

- name: Node.js 18.x
node-version: "18.14"

- name: Node.js 19.x
node-version: "19.6"

- name: Node.js 20.x
node-version: "20.12"

- name: Node.js 21.x
node-version: "21.7"

- name: Node.js 22.x
node-version: "22.0"

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: Install Node.js ${{ matrix.node-version }}
shell: bash -eo pipefail -l {0}
Expand All @@ -131,7 +151,12 @@ jobs:
dirname "$(nvm which ${{ matrix.node-version }})" >> "$GITHUB_PATH"
- name: Configure npm
run: npm config set shrinkwrap false
run: |
if [[ "$(npm config get package-lock)" == "true" ]]; then
npm config set package-lock false
else
npm config set shrinkwrap false
fi
- name: Remove npm module(s) ${{ matrix.npm-rm }}
run: npm rm --silent --save-dev ${{ matrix.npm-rm }}
Expand Down Expand Up @@ -190,7 +215,7 @@ jobs:
needs: test
runs-on: ubuntu-latest
steps:
- name: Uploade code coverage
- name: Upload code coverage
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.github_token }}
Expand Down

0 comments on commit eada099

Please sign in to comment.