Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Handlebars inspections #18

Closed
picimako opened this issue May 16, 2022 · 1 comment
Closed

Extend Handlebars inspections #18

picimako opened this issue May 16, 2022 · 1 comment
Assignees
@picimako
Labels
enhancement Improvement on an existing feature
Milestone
v1.0.3

Comments

@picimako
Copy link
Owner

Summary

There are some helper specific checks that could be added to the Handlebars helper inspections.

Tasks

  • pickRandom doesn't make sense if there is only one literal specified.
  • The padding hash of base64 is applicable only during encoding.
  • In case of math, if there are exactly 3 parameters specified, the middle one being a string literal, validate if it is one of the supported operations
@picimako picimako added the enhancement Improvement on an existing feature label May 16, 2022
@picimako picimako added this to the v1.0.3 milestone May 16, 2022
@picimako picimako self-assigned this May 23, 2022
@picimako picimako assigned picimako and unassigned picimako Jun 13, 2022
@picimako
Copy link
Owner Author

picimako commented Jun 14, 2022 •
edited
Loading

Completed in v1.0.3. base64 padding has validation will be implemented in a future issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@picimako picimako

Labels
enhancement Improvement on an existing feature
Projects
None yet
Milestone
v1.0.3
Development

No branches or pull requests
1 participant
@picimako