Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ok().withBody().withHeader() to okJson()/okXml()/okTextXml() directly #126

Closed
picimako opened this issue Nov 4, 2024 · 1 comment
Closed

Convert ok().withBody().withHeader() to okJson()/okXml()/okTextXml() directly #126

picimako opened this issue Nov 4, 2024 · 1 comment
Assignees
@picimako
Labels
enhancement Improvement on an existing feature
Milestone
v1.0.36

Comments

@picimako
Copy link
Owner

picimako commented Nov 4, 2024

Summary

Currently ok().withBody("").withHeader("Content-Type", "application/json") call chains are suggested to be simplified as okForContentType("application/json", "") but could be simplified directly as okJson("")

Tasks

  • Add a new quick fix for the mentioned case.
@picimako picimako added the enhancement Improvement on an existing feature label Nov 4, 2024
@picimako picimako added this to the v1.0.36 milestone Nov 4, 2024
@picimako picimako changed the title Convert ok().withBody().withHeader(, "application/json") to okJson() directly Convert ok().withBody().withHeader() to okJson()/okXml()/okTextXml() directly Nov 4, 2024
@picimako picimako self-assigned this Nov 4, 2024
@picimako
Copy link
Owner Author

picimako commented Nov 4, 2024

Completed in v1.0.36.

@picimako picimako closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@picimako picimako

Labels
enhancement Improvement on an existing feature
Projects
None yet
Milestone
v1.0.36
Development

No branches or pull requests
1 participant
@picimako