Fix default method parameter value mentioning ::class constant

Author: ondrejmirtes

composer.json

@@ -23,7 +23,7 @@
 		"nette/utils": "^3.1.3",
 		"nikic/php-parser": "4.10.4",
 		"ondram/ci-detector": "^3.4.0",
-		"ondrejmirtes/better-reflection": "4.3.51",
+		"ondrejmirtes/better-reflection": "4.3.52",
 		"phpdocumentor/reflection-docblock": "4.3.4",
 		"phpstan/php-8-stubs": "^0.1.13",
 		"phpstan/phpdoc-parser": "^0.4.9",

composer.lock

@@ -2,9 +2,12 @@
 
 namespace PHPStan\Analyser;
 
+use Bug4713\Service;
 use PHPStan\Broker\Broker;
 use PHPStan\File\FileHelper;
+use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Reflection\SignatureMap\SignatureMapProvider;
+use PHPStan\Type\Constant\ConstantStringType;
 use const PHP_VERSION_ID;
 use function array_reverse;
 
@@ -336,6 +339,19 @@ public function testBug1843(): void
 		$this->assertCount(0, $errors);
 	}
 
+	public function testBug4713(): void
+	{
+		$errors = $this->runAnalyse(__DIR__ . '/data/bug-4713.php');
+		$this->assertCount(0, $errors);
+
+		$reflectionProvider = $this->createBroker();
+		$class = $reflectionProvider->getClass(Service::class);
+		$parameter = ParametersAcceptorSelector::selectSingle($class->getNativeMethod('createInstance')->getVariants())->getParameters()[0];
+		$defaultValue = $parameter->getDefaultValue();
+		$this->assertInstanceOf(ConstantStringType::class, $defaultValue);
+		$this->assertSame(Service::class, $defaultValue->getValue());
+	}
+
 	/**
 	 * @param string $file
 	 * @return \PHPStan\Analyser\Error[]

tests/PHPStan/Analyser/AnalyserIntegrationTest.php

@@ -0,0 +1,15 @@
+<?php
+
+namespace Bug4713;
+
+class Service
+{
+	public static function createInstance(string $class = self::class): Service
+	{
+		return new $class();
+	}
+}
+
+function (): void {
+	$service = Service::createInstance();
+};