ClassReflection::getConstant() - do not crash on unknown declaring class

ondrejmirtes · ondrejmirtes · commit 00e3090d373a · 2020-04-23T19:11:46.000+02:00
diff --git a/src/Reflection/ClassReflection.php b/src/Reflection/ClassReflection.php
@@ -608,7 +608,13 @@ public function getParentClassesNames(): array
 
 	public function hasConstant(string $name): bool
 	{
-		return $this->getNativeReflection()->hasConstant($name);
+		if (!$this->getNativeReflection()->hasConstant($name)) {
+			return false;
+		}
+
+		$reflectionConstant = $this->getNativeReflection()->getReflectionConstant($name);
+
+		return $this->reflectionProvider->hasClass($reflectionConstant->getDeclaringClass()->getName());
 	}
 
 	public function getConstant(string $name): ConstantReflection

Original file line number	Diff line number	Diff line change
`@@ -608,7 +608,13 @@ public function getParentClassesNames(): array`
`608`	`608`
`609`	`609`	`public function hasConstant(string $name): bool`
`610`	`610`	`{`
`611`		`- return $this->getNativeReflection()->hasConstant($name);`
	`611`	`+ if (!$this->getNativeReflection()->hasConstant($name)) {`
	`612`	`+ return false;`
	`613`	`+ }`
	`614`	`+`
	`615`	`+ $reflectionConstant = $this->getNativeReflection()->getReflectionConstant($name);`
	`616`	`+`
	`617`	`+ return $this->reflectionProvider->hasClass($reflectionConstant->getDeclaringClass()->getName());`
`612`	`618`	`}`
`613`	`619`
`614`	`620`	`public function getConstant(string $name): ConstantReflection`