Remove major version from apache module #3769
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the major version in the SO/module name doesn't make a lot of sense to me, as our ABI stability guarantees apply to minor versions. Unless we want to include both the major and minor version here, we should just drop it entirely.
We don't include major/minor version in other artifacts either and leave it to distros to rename binaries to their liking (
php-7.2
etc).The only other place where we include the major version number in artifacts are the primary Windows DLLs (
php7ts.dll
). Maybe @weltling can comment on why that is done?