Implement GH-17321: Add setAuthorizer to Pdo\Sqlite #17905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
force-pushed
the
fix-17321
branch
2 times, most recently
from
54cbc00 to
a833811
Compare
nielsdos
commented
Feb 23, 2025
| @@ -33,6 +33,16 @@ class Sqlite extends \PDO | |||
| /** @cvalue PDO_SQLITE_ATTR_EXTENDED_RESULT_CODES */ | |||
| public const int ATTR_EXTENDED_RESULT_CODES = UNKNOWN; | |||
|
|
|||
| /** @cvalue SQLITE_OK */ | |||
| public const int OK = UNKNOWN; | |||
There was a problem hiding this comment.
These could be enums in theory for the authorizer callback, although OK is more generally applicable too
TimWolla
reviewed
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.