-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: short and inner classes #17895
Draft
withinboredom
wants to merge
20
commits into
php:master
Choose a base branch
from
bottledcode:rfc/short-class2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
RFC: short and inner classes #17895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
884ef92
to
3803151
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a draft RFC I am working on: https://wiki.php.net/rfc/short-and-inner-classes
What it does:
Future work:
ZEND_ACC_SHORT_SYNTAX
, but it is the most straightforward solution -- however, this feature takes the last slot; which may not be ideal.Inner classes basically work by making some changes to the grammar to allow for inner classes to be defined and referenced -- both as a type and as an instance of that type. There is no supporting grammar for using them in
extends
(mostly because I couldn't work out a way to make it unambiguous).From there, there are some supporting modifications during compilation where we do a bit of house keeping:
And finally, we do some things at runtime to properly resolve the inner class (such as autoloading the outer class).
Feel free to review this work in progress if you'd like. I'm familiar with the internals of PHP, but I am by no means an expert, so any suggestions are appreciated.