ext/standard: inet_ntop internal change. #17830
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual buffer size is too small for ipv6, should be INET6_ADDRSTRLEN (46) also the size of the buffer should be set accordingly to the family.
|
note that I set on master purposely as it is not really a bug fix per say. let me know if you disagree. |
mvorisek
reviewed
Feb 17, 2025
| @@ -544,7 +544,8 @@ PHP_FUNCTION(inet_ntop) | |||
| char *address; | |||
| size_t address_len; | |||
| int af = AF_INET; | |||
| char buffer[40]; | |||
| socklen_t buffersize = INET_ADDRSTRLEN; | |||
| char buffer[INET6_ADDRSTRLEN]; | |||
There was a problem hiding this comment.
Is anything INET6_* defined when HAVE_IPV6 is not?
Also, is it safe to use shorter buffersize when compiled /wo IPv6 support and then run on system /w IPv6 support?
There was a problem hiding this comment.
Is anything
INET6_*defined whenHAVE_IPV6is not?
Yes it is independant from ipv6 support and, alone, does not indicate the system supports it.
Also, is it safe to use shorter
buffersizewhen compiled /wo IPv6 support and then run on system /w IPv6 support?
Yes in that case the best course is to reverse the logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual buffer size is too small for ipv6, should be INET6_ADDRSTRLEN (46) also the size of the buffer should be set accordingly to the family.