Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run prime-docker-cache on ubuntu-22.04 #719

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

rjaegers
Copy link
Member

🚀 Hey, I have created a Pull Request

Description of changes

Running the emulated arm64 build causes a segfault on Ubuntu 24.04 at the moment. This PR switches the default runner (based on Ubuntu 24.04) back to the previous version for the prime cache workflow.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner February 10, 2025 18:06
Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:3bc465ca934e262329f6bb7a748d9b0bbffb2fe6fb9a0cfb7e4e436fd7b1c0a8

OS/Platform Previous Size Current Size Delta
linux/amd64 475.28M 483.96M 8.68M (+1.83%)
linux/arm64 614.64M 623.06M 8.42M (+1.37%)

Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 17 0 0.07s
✅ DOCKERFILE hadolint 2 0 0.5s
✅ GHERKIN gherkin-lint 2 0 0.86s
✅ JSON npm-package-json-lint yes no 0.35s
✅ JSON prettier 15 1 0 0.35s
✅ JSON v8r 14 0 8.78s
✅ MARKDOWN markdownlint 8 0 0 0.89s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.21s
✅ REPOSITORY checkov yes no 15.66s
✅ REPOSITORY gitleaks yes no 0.89s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 10.21s
✅ REPOSITORY secretlint yes no 1.02s
✅ REPOSITORY syft yes no 1.15s
✅ REPOSITORY trivy yes no 5.7s
✅ REPOSITORY trivy-sbom yes no 0.08s
✅ REPOSITORY trufflehog yes no 7.77s
✅ SPELL lychee 58 0 2.3s
✅ YAML prettier 22 0 0 0.63s
✅ YAML v8r 22 0 6.42s
✅ YAML yamllint 22 0 0.39s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

Copy link
Contributor

Test Results

 2 files  ±0   2 suites  ±0   1m 20s ⏱️ -3s
29 tests ±0  29 ✅ ±0  0 💤 ±0  0 ❌ ±0 
31 runs  ±0  31 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 05c746c. ± Comparison against base commit 76e6cc6.

@rjaegers rjaegers enabled auto-merge February 10, 2025 21:35
Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:0a3449c35be3053b960e6295f88aa58fd8145927fac0b0ee9ddbc3c3857211f8

OS/Platform Previous Size Current Size Delta
linux/amd64 686.88M 697.82M 10.94M (+1.59%)
linux/arm64 668.62M 670.26M 1.64M (+0.25%)

@rjaegers rjaegers added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit b48ed5a Feb 11, 2025
22 checks passed
@rjaegers rjaegers deleted the feature/fix-docker-prime-cache-build branch February 11, 2025 04:59
Copy link
Contributor

Pull Request Report (#719)

Static measures

Description Value
Number of added lines 2
Number of deleted lines 2
Number of changed files 2
Number of commits 2
Number of reviews 2
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 2
Get the total number of participants of a Pull Request 5

Time related measures

Description Value
PR lead time (from creation to close of PR) 10.9 Hours
Time that was spend on the branch before the PR was created 2.1 Min
Time that was spend on the branch before the PR was merged 10.9 Hours
Time to merge after last review 8.9 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 5.9 Hours
Total time spend in last status check run on PR 5.5 Hours

Copy link
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v5.6.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants