Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close process on coroutine cancelation #5

Closed
Syer10 opened this issue Jul 9, 2021 · 2 comments
Closed

Close process on coroutine cancelation #5

Syer10 opened this issue Jul 9, 2021 · 2 comments

Comments

@Syer10
Copy link

Syer10 commented Jul 9, 2021

I have another app that I run alongside my application, and I want it to be closed with my application, for this currently I use Runtime.exec, but I was thinking of trying out this library as Runtime.exec has issues with the way I am using it. It doesn't seem to close the attached process on coroutine cancellation though, which I feel would fit with the way the library is built.

@pgreze
Copy link
Owner

pgreze commented Aug 3, 2021

(Sorry for the late answer...)
I agree with you, by default the process should be stopped when the coroutine is cancelled.
Let me investigate on the best way to handle cancellation in async calls.

@pgreze
Copy link
Owner

pgreze commented Aug 5, 2021

@Syer10 I just released the version 1.3 with cancellation support.

@pgreze pgreze closed this as completed Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants