Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quat.fromTo should check for negligible values #26

Closed
dmnsgn opened this issue Apr 28, 2021 · 0 comments · Fixed by #27
Closed

quat.fromTo should check for negligible values #26

dmnsgn opened this issue Apr 28, 2021 · 0 comments · Fixed by #27
Labels
type/feat A new feature

Comments

@dmnsgn
Copy link
Member

dmnsgn commented Apr 28, 2021

Both Three.js and gl-matrix implementation check the dot product for Number.EPSILON or 0.000001.

https://github.com/toji/gl-matrix/blob/fccd5f707432ec5cc1774575be84c9f901a198d0/src/quat.js#L699-L727

https://github.com/mrdoob/three.js/blob/d4aa9e00ea29808534a3e082f602c544e5f2419c/src/math/Quaternion.js#L363-L404
@vorg vorg mentioned this issue Oct 14, 2022
Closed
@dmnsgn dmnsgn added type/feat A new feature and removed enhancement labels Jan 29, 2024
@dmnsgn dmnsgn mentioned this issue Feb 5, 2024
Merged
31 tasks
@dmnsgn dmnsgn closed this as completed in #27 Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feat A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

V4 pex-gl/pex-math
1 participant
@dmnsgn