-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use updated ICS23 proof spec supporting noninclusion proofs #2391
Comments
Discussed with the group today, and added the WIP PR #2392 as an early blocker. Once that lands, we can focus on the other tasks. Given team schedule, it's likely to be @avahowell and @erwanor driving this work to completion today and tomorrow. |
For some reason I thought that So this is blocked on those two crate releases. Let's see how things go on Monday; one possibility is that we can consume them, possibly delaying the release a day or two; another is that we stick to the schedule and let the ICS23 changes slip. |
@hdevalence a third, more sinister, option is to fork ibc-proto-rs with the right vendored ics23 protogen'd: https://github.com/penumbra-zone/ibc-proto-rs/tree/vendor_ics23 and plug back into upstream for testnet 52. |
Sure, that's a good thing to consider as a temporary measure -- we should definitely avoid a long-term fork of those crates, though. |
I copied the branch that is supposed to be merged and fix our problem into our repo: https://github.com/penumbra-zone/ibc-proto-rs/tree/penumbra |
@hdevalence thanks, i'll use it to get ahead of the monday release. |
I'm working on an update to |
Moved to testnet 53, as a result of #2032 getting delayed. |
Will be closed by #2628 |
Is your feature request related to a problem? Please describe.
Now that we've been able to merge our extensions to ICS23 upstream, we should ensure that we ship a version of Penumbra that uses the correct ICS23 proof spec. This is important to do as part of the next testnet release, because otherwise, we'll have
testnet
andtestnet-preview
using different proof specs, and the relayer doesn't know how to support that (and shouldn't need to, because there should just be one correct proof spec).Describe the solution you'd like
Getting this done has a somewhat deep dependency chain, so we should focus to make sure we get all of the steps done in time:
jmt
crate usesics23 = "0.10"
and has the correct proof specjmt
crate, partially done in storage: integration ofjmt@0.4.0
& reverse index for jmt key hashes #2032 ...ibc
0.37
#2374, which is impossible ...penumbra_app
to useibc-types
0.1.0
. #2380pub
ibc-types#2ibc-types
methods into the IBC component. #2381The text was updated successfully, but these errors were encountered: