Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated ICS23 proof spec supporting noninclusion proofs #2391

Closed
6 of 7 tasks
hdevalence opened this issue Apr 19, 2023 · 9 comments · Fixed by #2628
Closed
6 of 7 tasks

Use updated ICS23 proof spec supporting noninclusion proofs #2391

hdevalence opened this issue Apr 19, 2023 · 9 comments · Fixed by #2628
Assignees

Comments

@hdevalence
Copy link
Member

hdevalence commented Apr 19, 2023

Is your feature request related to a problem? Please describe.

Now that we've been able to merge our extensions to ICS23 upstream, we should ensure that we ship a version of Penumbra that uses the correct ICS23 proof spec. This is important to do as part of the next testnet release, because otherwise, we'll have testnet and testnet-preview using different proof specs, and the relayer doesn't know how to support that (and shouldn't need to, because there should just be one correct proof spec).

Describe the solution you'd like

Getting this done has a somewhat deep dependency chain, so we should focus to make sure we get all of the steps done in time:

@conorsch
Copy link
Contributor

Discussed with the group today, and added the WIP PR #2392 as an early blocker. Once that lands, we can focus on the other tasks. Given team schedule, it's likely to be @avahowell and @erwanor driving this work to completion today and tomorrow.

@hdevalence
Copy link
Member Author

For some reason I thought that ibc-proto 0.30.0 included the ICS23 changes already, but that's not the case: penumbra-zone/ibc-types#3 (comment)

So this is blocked on those two crate releases. Let's see how things go on Monday; one possibility is that we can consume them, possibly delaying the release a day or two; another is that we stick to the schedule and let the ICS23 changes slip.

@erwanor
Copy link
Member

erwanor commented Apr 24, 2023

@hdevalence a third, more sinister, option is to fork ibc-proto-rs with the right vendored ics23 protogen'd: https://github.com/penumbra-zone/ibc-proto-rs/tree/vendor_ics23 and plug back into upstream for testnet 52.

@hdevalence
Copy link
Member Author

Sure, that's a good thing to consider as a temporary measure -- we should definitely avoid a long-term fork of those crates, though.

@conorsch conorsch moved this from Testnet 51: Elara to Testnet 52: Amalthe in Testnets Apr 24, 2023
@hdevalence
Copy link
Member Author

I copied the branch that is supposed to be merged and fix our problem into our repo: https://github.com/penumbra-zone/ibc-proto-rs/tree/penumbra

@erwanor
Copy link
Member

erwanor commented Apr 28, 2023

@hdevalence thanks, i'll use it to get ahead of the monday release.

@hdevalence
Copy link
Member Author

I'm working on an update to ibc-types at the moment.

@erwanor
Copy link
Member

erwanor commented May 10, 2023

Moved to testnet 53, as a result of #2032 getting delayed.

@erwanor erwanor moved this from Testnet 52: Amalthe to Testnet 53: Himalia in Testnets May 10, 2023
@redshiftzero redshiftzero moved this from Testnet 53: Himalia to In Progress in Testnets May 26, 2023
@redshiftzero
Copy link
Contributor

Will be closed by #2628

@github-project-automation github-project-automation bot moved this from In Progress to Testnet 53: Himalia in Testnets May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Testnet 53: Himalia
Development

Successfully merging a pull request may close this issue.

4 participants