Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: My Trades #319

Closed
4 tasks done
erwanor opened this issue Jan 26, 2025 · 1 comment
Closed
4 tasks done

Tracking issue: My Trades #319

erwanor opened this issue Jan 26, 2025 · 1 comment
Assignees

Comments

@erwanor
Copy link
Member

erwanor commented Jan 26, 2025

Image

In order to render My Trades, we need to make a collection of changes across the application stack:

  1. view: extend the ViewService with a method to query latest activity #320

Docs: https://buf.build/penumbra-zone/penumbra/docs/main:penumbra.view.v1

Suggested API:

service ViewService {
  // …
  rpc LatestSwaps(LatestSwapsRequest) returns (stream LatestSwapsResponse);
}

message LatestSwapsRequest {
  // If present, filter balances to only include the account specified by the `AddressIndex`.
  core.keys.v1.AddressIndex account_filter = 1;
  // If present, filter balances to only include trading activity on the specified pair.
  core.dex.v1.DirectedTradingPair pair = 2;
  // If present, limit the responses to activity that occured after this block height.
  uint64 after_height = 3;
  // Limit the response to the last entries within `response_limit`.
  uint64 response_limit = 4;
}

message LatestSwapsResponse {
  core.dex.v1.DirectedTradingPair pair = 1;
  core.asset.v1.Value input = 2;
  core.asset.v1.Value output = 3;
  uint64 block_height = 4;
  core.txhash.v1.TransactionId id = 5;
}
  1. prax: implement LatestSwaps in prax #326
  2. explorer: pull rich swap execution data from pindexer #327
  3. explorer: render recent trades #328
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Jan 26, 2025
@erwanor erwanor moved this from 🗄️ Backlog to Tracking issues in Penumbra web Jan 27, 2025
@TalDerei TalDerei assigned TalDerei and unassigned TalDerei Jan 27, 2025
@TalDerei TalDerei pinned this issue Jan 28, 2025
@TalDerei TalDerei unpinned this issue Jan 28, 2025
@VanishMax
Copy link
Contributor

@erwanor do we close this issue or wait for pindexer bug fix? penumbra-zone/penumbra#5054

@erwanor erwanor closed this as completed Feb 12, 2025
@github-project-automation github-project-automation bot moved this from Tracking issues to ✅ Done in Penumbra web Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants