Skip to content

149 rankifyinstance fellowship contract #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 44 commits into
base: main
Choose a base branch
from
Draft

149 rankifyinstance fellowship contract #156

wants to merge 44 commits into from

Conversation

peersky
Copy link
Member

@peersky peersky commented Mar 14, 2025

No description provided.

@peersky peersky linked an issue Mar 14, 2025 that may be closed by this pull request
RankifyInstance -> CVPP instance #149
Open
5 tasks
@peersky peersky marked this pull request as draft March 14, 2025 08:48
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 3448e9e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
rankify-contracts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

peersky and others added 24 commits March 14, 2025 16:51
@peersky
Delete src/interfaces/IFellowship.sol
61cb3b6
@peersky
keep libcoinvending internal
d540527
@peersky
Merge branch '149-rankifyinstance---fellowship-contract' of github.co…
31df3be 
…m:peeramid-labs/contracts into 149-rankifyinstance---fellowship-contract
@peersky
wip for tests & scripts
89fcc83
@peersky
Allow updating fellowship metadata (#157)
0f7bf8f 
* fellowship metadata now can be edited

* rm hooks for now for uri setters

* prettier

* allow updating fellowship metadata & test

* changeset

* Delete .changeset/shiny-seahorses-know.md
@peersky
deployment arts (#155)
47ac917
@peersky
add zkey and verifier to version control
7da849e
@peersky
add owner to create subject
4ef5bf3
@peersky
Make game is canceled more explicit (#158)
7e577dd 
* made game canceled state more explicit

* lint

* rm excessive compile logging
@peersky
restore commented code
2fb2f37
@peersky
fixing not a typo
f4d2863
@peersky
changesets
90bbecd
@peersky
redeployment
d153a41
@peersky
hardhat verify config for arb sepolia
00cb66b
@peersky
update prettier config
b49bc21
@peersky
prettierignore
f3ba0fb
@peersky
console log silence
f21c8af
@peersky
Merge branch 'main' into 149-rankifyinstance---fellowship-contract
c927f1c
@peersky
Merge branch 'main' into dev
1ffda01
@peersky
separate dir for zk compilation
72adf92
@peersky
moved zk compile to separate cmd
ccc7dae
@peersky
add zk artifacts types to version control & copy them upon compile to…
0983aaa 
… compilation directory
@peersky
add end turn logs
b0a6cb0
@peersky
linter config update
6fd0497
peersky and others added 17 commits March 31, 2025 07:53
@peersky
Merge branch 'main' into 149-rankifyinstance---fellowship-contract
7fbce69
@peersky
Merge branch 'main' into dev
789ce51
@peersky
Merge branch 'main' into 149-rankifyinstance---fellowship-contract
10b3db3
@peersky
wip
91f385a
@peersky
added test when players do not make moves at all (#164)
302efbc 
* added test when players do not make moves at all

* case if there is one proposal on turn 1 and none other activity
@theKosmoss @peersky
Created unit test that proves bug (#165)
32420c2 
* Created unit test that proves bug

* Contract fix & test refinement

* debug session with kosmoss

* happy linter - happy .life

---------

Co-authored-by: Tim Pechersky <tim.pechersky@gmail.com>
@peersky
Merge branch 'main' into dev
1942073
@peersky
fixing game turn states boundry cases
c9b09b1
@peersky
Merge branch 'dev' of github.com:peeramid-labs/contracts into dev
5a2ff65
@peersky
test fixes
e259a31
@peersky
small fix
e71a988
@peersky
upd deploy arts
1979e6b
@peersky
cs
4c97469
@peersky
Merge branch 'main' into 149-rankifyinstance---fellowship-contract
aeacd23
@peersky
Merge branch 'dev' into 149-rankifyinstance---fellowship-contract
b8c5bb5
@peersky
wip
231a81a
@peersky
test wip
3448e9e
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 21, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RankifyInstance -> CVPP instance
2 participants
@peersky @theKosmoss