Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme tester #1641

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Theme tester #1641

merged 5 commits into from
Jan 2, 2024

Conversation

meeuw
Copy link
Contributor

@meeuw meeuw commented Dec 11, 2023

Theme tester

I've formatted the code using black and validated using pylint.

Pylint doesn't like the calls to protected members in theme, but theme doesn't have a usable API for this.

If you want I can add this API to theme?

@pazz
Copy link
Owner

pazz commented Dec 12, 2023

Could you run pyflakes or some other auto-linter over this please, just so that codeclimate does not complain too much for silly things.
Also, It'd be good if this was mentioned in the docs somewhere, like "try the script .. to test your theme file..".
Perhaps you can use argparse in the script to give some ad hoc help, although it is pretty obvious how to use it.
Cheers!

@meeuw
Copy link
Contributor Author

meeuw commented Dec 27, 2023

✔️ fixed your remarks, pushed codeclimate to the edge...

Copy link
Owner

@pazz pazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pazz pazz merged commit 2c5dc0d into pazz:master Jan 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants