Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external tmux command without display #1605

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

MacGyverNL
Copy link
Contributor

I spent entirely too long today fixing my own instance of #1560, because I'm not running alot in X11 and #460 and 2a7d1fd make alot simply fall back to non-spawning behaviour silently.

Initially I special-cased tmux outside of X11 in alot/commands/globals.py, but then I found out that I'm supposed to write a hook. So I did that, but I'd like to document it publicly.

There's also a bug where the thread result of that hook is not respected because self.in_thread gets set directly.

Don't fail silently. I'd prefer an actual ui notification, but in the
init the ui isn't available.
@MacGyverNL MacGyverNL force-pushed the fix-ext-command-without-display branch from 8723976 to 08895e2 Compare September 13, 2022 22:12
@pazz
Copy link
Owner

pazz commented Sep 14, 2022

Looks good to me. thanks!

@pazz pazz merged commit 77e0080 into pazz:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants