Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Async Rendering #707

Closed
5 tasks
bmuenzenmeyer opened this issue Oct 4, 2017 · 7 comments
Closed
5 tasks

Support Async Rendering #707

bmuenzenmeyer opened this issue Oct 4, 2017 · 7 comments
Assignees
Labels
pinned 📌 Don't let stalebot clean this up staged for next release 🏁
Milestone

Comments

@bmuenzenmeyer
Copy link
Member

bmuenzenmeyer commented Oct 4, 2017

This one's for you, @geoffp

Somehow we never made an issue for this.

This should support a number of endeavors we are pursuing:

  • React Engine
  • Twig Engine
  • Liquid Engine
  • Web/HTTP?
  • Performance Increases?
@bmuenzenmeyer bmuenzenmeyer added this to the 3.0.0 milestone Oct 4, 2017
@sghoweri
Copy link
Contributor

sghoweri commented Oct 9, 2017

^ also add native PHP Twig support to this as well.

Spent most of the day today spinning my wheels trying to get async PHP-based Twig templates working with some level of success (success in that I can get compiled template responses from the PHP side of the house + managed to hack together some critically needed file path info that's required for those templates to compile successfully) however without a callback or support for Promises (or something to that effect) I'm hitting a bit of a brick wall here. =/

CC @EvanLovely

@bmuenzenmeyer
Copy link
Member Author

bmuenzenmeyer commented Oct 10, 2017

also add native PHP Twig support to this as well.

Added

Spent most of the day today spinning my wheels trying to get async PHP-based Twig templates working with some level of success

@geoffp has the work in flight - I'd suggest we wait for it to land before moving forward with #554 and #285

@sghoweri
Copy link
Contributor

Yeah - I mentioned the same thing to Evan yesterday. Putting this on ice till async support lands.

@geoffp
Copy link
Contributor

geoffp commented Oct 11, 2017

I'm on it. I'll make time this week and next.

@tburny
Copy link

tburny commented Oct 18, 2017

I'd like to suggest testing with https://github.com/tburny/patternengine-node-noop if it is useful somehow :)

@stale
Copy link

stale bot commented Dec 17, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@geoffp
Copy link
Contributor

geoffp commented Jan 16, 2018

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned 📌 Don't let stalebot clean this up staged for next release 🏁
Projects
None yet
Development

No branches or pull requests

4 participants