From 738f2e720fee6ef41fce5b7995ea40de4dc61288 Mon Sep 17 00:00:00 2001 From: Javier Viola Date: Fri, 11 Nov 2022 12:30:04 +0000 Subject: [PATCH 1/2] Check if tracing is enabled --- javascript/packages/orchestrator/src/orchestrator.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/javascript/packages/orchestrator/src/orchestrator.ts b/javascript/packages/orchestrator/src/orchestrator.ts index 17124e2c9..79e74e25d 100644 --- a/javascript/packages/orchestrator/src/orchestrator.ts +++ b/javascript/packages/orchestrator/src/orchestrator.ts @@ -407,7 +407,7 @@ export async function start( const monitorIsAvailable = await client.isPodMonitorAvailable(); let jaegerUrl: string; - if (client.providerName === "podman") { + if (client.providerName === "podman" && networkSpec.settings.enable_tracing) { const jaegerIp = await client.getNodeIP("tempo"); jaegerUrl = `${jaegerIp}:6831`; } else if ( From d4bbf606897682172dcbbb7b8c9cb7b4fc18241a Mon Sep 17 00:00:00 2001 From: Javier Viola Date: Fri, 11 Nov 2022 10:01:24 -0300 Subject: [PATCH 2/2] fmt --- javascript/packages/orchestrator/src/orchestrator.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/javascript/packages/orchestrator/src/orchestrator.ts b/javascript/packages/orchestrator/src/orchestrator.ts index 79e74e25d..b89cd54ef 100644 --- a/javascript/packages/orchestrator/src/orchestrator.ts +++ b/javascript/packages/orchestrator/src/orchestrator.ts @@ -407,7 +407,10 @@ export async function start( const monitorIsAvailable = await client.isPodMonitorAvailable(); let jaegerUrl: string; - if (client.providerName === "podman" && networkSpec.settings.enable_tracing) { + if ( + client.providerName === "podman" && + networkSpec.settings.enable_tracing + ) { const jaegerIp = await client.getNodeIP("tempo"); jaegerUrl = `${jaegerIp}:6831`; } else if (