Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

artifacts: Remove polkadot_tmp.scale artifact #860

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Conversation

lexnv
Copy link
Collaborator

@lexnv lexnv commented Mar 13, 2023

The artifacts/polkadot_metadata_tmp.scale was added by mistake in #841.

This PR removes that file and ensures all files from ./artifacts are ignored by git, except the polkadot_metadata.scale.

lexnv added 2 commits March 13, 2023 17:53
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
.gitignore Outdated
cargo-timing*
artifacts/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong feelings, but it doesn't feel to me that this is a folder that should be used for putting test files any more than any other :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that's right, I've reverted this git rule as people could place their files in other places and under other names :D

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv merged commit de247f9 into master Mar 13, 2023
@lexnv lexnv deleted the lexnv/fix_artifacts branch March 13, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants