Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Send a message to a remote indicating the reason why we close it #1728

Open
tomaka opened this issue Feb 7, 2019 · 2 comments
Open

Send a message to a remote indicating the reason why we close it #1728

tomaka opened this issue Feb 7, 2019 · 2 comments
Labels
J0-enhancement An additional feature request. U3-nice_to_have Issue is worth doing eventually.
Milestone
Ideas

Comments

@tomaka
Copy link
Contributor

tomaka commented Feb 7, 2019

Right now it's hard to debug disconnects in Substrate substreams because it's simply the substream getting dropped.
We should transmit a message right before closing the substream, indicating the reason why the substream is getting dropped.
@gavofyork gavofyork added the J0-enhancement An additional feature request. label Feb 8, 2019
@gavofyork gavofyork added this to the As-and-when milestone Feb 8, 2019
@tomaka
Copy link
Contributor Author

tomaka commented Jul 24, 2019

Triaging.

We're now using the PSM to determine whether we should be connected to a node, and the PSM is based purely on reputation values. Therefore the reason for disconnecting is always going to be either "you sent a bad message" (which should happen very rarely), or "your reputation is too low" (which isn't very helpful).

@tomaka
Copy link
Contributor Author

tomaka commented Apr 14, 2020

cc libp2p/go-libp2p#872 libp2p/go-libp2p#238

@the-right-joyce the-right-joyce moved this to Backlog 🗒 in Networking Aug 25, 2022
@altonen altonen added the U3-nice_to_have Issue is worth doing eventually. label Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
J0-enhancement An additional feature request. U3-nice_to_have Issue is worth doing eventually.
Projects
Networking
Status: Backlog 🗒
Milestone
Ideas
Development

No branches or pull requests
3 participants
@gavofyork @tomaka @altonen