Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pallet revive: rpc build script should not panic #7786

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Mar 3, 2025

This can error when you use cargo remote and probably also with cargo vendor.
Still seeing two more build errors, but at least this one is fixed.

Other one:

error: set `DATABASE_URL` to use query macros online, or run `cargo sqlx prepare` to update the query cache
   --> substrate/frame/revive/rpc/src/receipt_provider/db.rs:123:17
    |
123 |               let result = query!(
    |  __________________________^
124 | |                 r#"
125 | |                 INSERT OR REPLACE INTO transaction_hashes (transaction_hash, block_hash, transaction_index)
126 | |                 VALUES ($1, $2, $3)
...   |
130 | |                 transaction_index
131 | |             )

and (maybe Rust version related, this is 1.84.1)

error[E0282]: type annotations needed
   --> substrate/frame/revive/rpc/src/receipt_provider/db.rs:102:34
    |
102 |         let (tx_result, logs_result) = tokio::join!(delete_transaction_hashes, delete_logs);
    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot infer type
    |
    = note: this error originates in the macro `$crate::join` which comes from the expansion of the macro `tokio::join` (in Nightly builds, run with -Z macro-backtrace for more info)

ggwpez added 2 commits March 3, 2025 20:16
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez requested review from pgherveou and nprt and removed request for pgherveou March 3, 2025 19:19
@ggwpez
Copy link
Member Author

ggwpez commented Mar 3, 2025

/cmd prdoc --bump patch --audience runtime_dev

@ggwpez ggwpez added T3-RPC_API This PR/Issue is related to RPC APIs. T2-pallets This PR/Issue is related to a particular pallet. and removed T3-RPC_API This PR/Issue is related to RPC APIs. labels Mar 3, 2025
@ggwpez ggwpez changed the title Make revive rpc build script not panics pallet revive: rpc build script should not panic Mar 3, 2025
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/13639423272
Failed job name: test-linux-stable

@bkchr bkchr enabled auto-merge March 3, 2025 20:47
@bkchr bkchr added T2-pallets This PR/Issue is related to a particular pallet. and removed T2-pallets This PR/Issue is related to a particular pallet. labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants