Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rpc module]: add easy way to register subscription without accept/reject API #735

Closed
Tracked by #736
niklasad1 opened this issue Apr 21, 2022 · 3 comments
Closed
Tracked by #736

[rpc module]: add easy way to register subscription without accept/reject API #735

niklasad1 opened this issue Apr 21, 2022 · 3 comments
Assignees
@lexnv
Milestone
[public] v1.0 and...

Comments

@niklasad1
Copy link
Member

#728 (comment)
@niklasad1 niklasad1 mentioned this issue Apr 22, 2022
Closed
9 tasks
@jsdw jsdw added this to the v1.0 milestone Jun 17, 2022
@lexnv lexnv self-assigned this Jun 21, 2022
@lexnv lexnv mentioned this issue Jun 21, 2022
Merged
@jsdw
Copy link
Collaborator

jsdw commented Jun 22, 2022

Given the other stuff we're working on, I suspect that we'll just end up closing this and accepting that the accept() API will be useful and not worth trying to avoid (also being able to pipe_from_stream on the pending sink makes it more ergonomic already)

@niklasad1
Copy link
Member Author

Yes 👍

@lexnv
Copy link
Contributor

lexnv commented Jun 29, 2022

Closed by: #799

@lexnv lexnv closed this as completed Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lexnv lexnv

Labels
None yet
Projects
None yet
Milestone
[public] v1.0 and move to maintenance
Development

No branches or pull requests
3 participants
@jsdw @niklasad1 @lexnv