Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove FutureDriver #1063

Closed
niklasad1 opened this issue Mar 30, 2023 · 0 comments · Fixed by #1080
Closed

remove FutureDriver #1063

niklasad1 opened this issue Mar 30, 2023 · 0 comments · Fixed by #1080

Comments

@niklasad1
Copy link
Member

niklasad1 commented Mar 30, 2023 •
edited
Loading

jsonrpsee has a custom FutureDriver::select_with(fut) which will check if there are any "finished tasks" in the task list along with polling fut

This adds a bunch of complexity and ideally it could be replaced by tokio::spawn to simplify things.
All these are already captured ina tokio spawn root task in so I'm not sure whether it makes things faster or worse.

Rather than that tokio::spawn requires everything to be 'static

This, this issue is to implement it and benchmark it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: replace FutureDriver with tokio::spawn paritytech/jsonrpsee
1 participant
@niklasad1