Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable cmd and args override in the statefulset #366

Merged
merged 2 commits into from
Feb 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/common/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: common
description: A generic helm chart for Kubernetes
type: application
version: 0.9.0
version: 0.10.0
maintainers:
- name: Parity
url: https://github.com/paritytech/helm-charts
2 changes: 1 addition & 1 deletion charts/common/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ This is intended behaviour. Make sure to run `git add -A` once again to stage ch
| nameOverride | string | `""` | Provide a name in place of node for `app:` labels |
| namespaceOverride | string | `""` | Provide a name to substitute for the full names of resources |
| nodeSelector | object | `{}` | Define which Nodes the Pods are scheduled on. |
| persistence | object | `{"accessModes":["ReadWriteOnce"],"annotations":{},"enabled":false,"size":"50Gi"}` | If enabled, creates a PVC and deploy the pod as statefulset |
| persistence | object | `{"accessModes":["ReadWriteOnce"],"annotations":{},"enabled":false,"size":"50Gi"}` | If enabled, creates a PVC and mounts it on /data and deploys the pod as statefulset |
| persistence.accessModes | list | `["ReadWriteOnce"]` | PVC access mode |
| persistence.annotations | object | `{}` | Annotations to add to the PVC |
| persistence.enabled | bool | `false` | Enable PVC creation |
Expand Down
6 changes: 6 additions & 0 deletions charts/common/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@ spec:
{{- toYaml .Values.containerSecurityContext | nindent 12 }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
{{- with .Values.command }}
command: {{- toYaml . | nindent 12 }}
{{- end }}
{{- with .Values.args }}
args: {{- toYaml . | nindent 12 }}
{{- end }}
ports:
{{- range $keys := .Values.service.ports }}
- name: {{ .name }}
Expand Down
2 changes: 1 addition & 1 deletion charts/common/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ startupProbe: {}
stateful:
annotations: {}

# -- If enabled, creates a PVC and deploy the pod as statefulset
# -- If enabled, creates a PVC and mounts it on /data and deploys the pod as statefulset
persistence:
# -- Enable PVC creation
enabled: false
Expand Down