Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛HMR Does not add new files that match an import glob #1833

Closed
DeMoorJasper opened this issue Aug 1, 2018 · 1 comment
Closed

🐛HMR Does not add new files that match an import glob #1833

DeMoorJasper opened this issue Aug 1, 2018 · 1 comment
Labels

Comments

@DeMoorJasper
Copy link
Member

🐛 bug report

If a glob import/require is used hmr/watch does not redo the glob, causing it to not automatically add new files if you added a file that matches the same glob pattern.

For example:

import files from './files/*.js';

File structure

index.js
files
- file.js
- otherfile.js

If you add a file for example anotherfile.js to the files folder, it will not cause a reload or update and will not include the file.

🎛 Configuration (.babelrc, package.json, cli command)

No config

🤔 Expected Behavior

Should reload and include the newly added file that matches the glob

😯 Current Behavior

You have to restart parcel to re-run the glob

💁 Possible Solution

Support globs in watch mode

🔦 Context

Using glob imports

🌍 Your Environment

Software Version(s)
Parcel 1.9.7
Node 8.11.3
npm/Yarn 6.2.0
Operating System OS X High Sierra
@DeMoorJasper DeMoorJasper changed the title 🐛Glob does not hmr, new files that match the pattern 🐛Glob does not hmr new files that match the pattern Aug 1, 2018
@DeMoorJasper DeMoorJasper changed the title 🐛Glob does not hmr new files that match the pattern 🐛HMR Does not add new files that match an import glob Aug 1, 2018
@DeMoorJasper DeMoorJasper mentioned this issue Oct 28, 2018
3 tasks
@github-actions github-actions bot added the Stale Inactive issues label Jan 17, 2020
@DeMoorJasper
Copy link
Member Author

Kinda still happens, but globs will get removed in v2.

This message is just to test the action 😅

@github-actions github-actions bot removed the Stale Inactive issues label Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant