Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use NetworkHandle to access num connected peers #1541

Merged
merged 2 commits into from
Feb 24, 2023
Merged

refactor: use NetworkHandle to access num connected peers #1541

merged 2 commits into from
Feb 24, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Feb 24, 2023

use the NetworkHandle, if network is up to fetch num connected peers instead of keeping track manually.

also moves to new module events

@mattsse mattsse requested a review from rkrasiuk February 24, 2023 10:42
@mattsse mattsse requested a review from onbjerg as a code owner February 24, 2023 10:42
@mattsse mattsse added C-debt A clean up/refactor of existing code A-cli Related to the reth CLI labels Feb 24, 2023
rkrasiuk
rkrasiuk approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit 3589879 into main Feb 24, 2023
@mattsse mattsse deleted the matt/use-network-to-access-connected-peers branch February 24, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI C-debt A clean up/refactor of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @rkrasiuk