Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.2.0 #38

Merged
merged 3 commits into from
Nov 11, 2021
Merged

Prepare 0.2.0 #38

merged 3 commits into from
Nov 11, 2021

Conversation

paolobarbolini
Copy link
Owner

There are still a few issues we'd like to fix. Opening this early just to signal that we're planning for a 0.2.0 release after it.

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #38 (a0f4da9) into main (036840b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files          26       26           
  Lines        1288     1288           
=======================================
  Hits         1184     1184           
  Misses        104      104           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 036840b...a0f4da9. Read the comment docs.

@paolobarbolini
Copy link
Owner Author

At least going from memory I don't think we have anything left before the 0.2.0 release

@malobre
Copy link
Contributor

malobre commented Nov 8, 2021

I had a quick glance at the code and the issue I described in #32 (comment) is also present here:

pub fn new<S: Into<String>>(key: S, secret: S) -> Self {

and here:
pub fn new_<S: Into<String>>(key: S, secret: S, token: Option<S>) -> Self {

Edit:
Also this comment:

/// For backwards compatibility this method was named `new_`, and will replace
/// the current `new` implementation in the 0.2.0 release.

@paolobarbolini paolobarbolini marked this pull request as ready for review November 11, 2021 08:09
@paolobarbolini paolobarbolini merged commit 52c162a into main Nov 11, 2021
@paolobarbolini paolobarbolini deleted the release-0.2.0 branch November 11, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants